优化目录结构

app/Endpoint/Api/Http/Controllers/AdController.php

@@ -0,0 +1,45 @@
+<?php
+
+namespace App\Endpoint\Api\Http\Controllers;
+
+use App\Endpoint\Api\Http\Resources\AdResource;
+use App\Models\AdAddress;
+use Illuminate\Http\Request;
+
+class AdController extends Controller
+{
+    /**
+     *
+     *
+     * @param \Illuminate\Http\Request $request
+     * @return void
+     */
+    public function index(Request $request)
+    {
+        $keys = (array) $request->query('keys');
+
+        if (empty($keys)) {
+            return response()->json([]);
+        }
+
+        $addresses = AdAddress::with([
+            'ads' => function ($query) {
+                $query->showable()->latest('sort');
+            },
+        ])->showable()->whereIn('key', $keys)->get();
+
+        $mapAddresses = $addresses->mapWithKeys(function ($item) use ($request) {
+            return [
+                $item->key => AdResource::collection($item->ads)->resolve($request),
+            ];
+        });
+
+        foreach ($keys as $key) {
+            if (! $mapAddresses->has($key)) {
+                $mapAddresses->put($key, []);
+            }
+        }
+
+        return response()->json($mapAddresses);
+    }
+}

app/Endpoint/Api/Http/Controllers/CaptchaController.php

@@ -1,7 +1,8 @@
 <?php
 
-namespace App\Http\Controllers\Api\V1;
+namespace App\Endpoint\Api\Http\Controllers;
 
+use App\Endpoint\Api\Http\Requests\StoreCaptchaRequest;
 use App\Services\CaptchaService;
 use Gregwar\Captcha\CaptchaBuilder;
 use Illuminate\Http\Request;
@@ -12,23 +13,19 @@ class CaptchaController extends Controller
     /**
      * 创建图形验证码
      *
-     * @param \Illuminate\Http\Request $request
+     * @param \App\Endpoint\Api\Http\Requests\StoreCaptchaRequest $request
      * @param \App\Services\CaptchaService $captchaService
      * @return \Illuminate\Http\Response
      */
-    public function store(Request $request, CaptchaService $captchaService)
+    public function store(StoreCaptchaRequest $request, CaptchaService $captchaService)
     {
-        $key = $request->filled('key') ? $request->input('key') : Str::random(16);
-
         $builder = $this->builder();
-        $builder->build(
-            (int) $request->input('w', 150),
-            (int) $request->input('h', 40),
-        );
+        $builder->build($request->input('w', 150), $request->input('h', 40));
 
-        if (strlen($key) <= 32) {
-            $captchaService->put($key, $builder->getPhrase());
-        }
+        $captchaService->put(
+            $key = $request->input('key', Str::random(16)),
+            $builder->getPhrase()
+        );
 
         return response()->json([
             'key' => $key,

app/Endpoint/Api/Http/Controllers/Controller.php

@@ -0,0 +1,15 @@
+<?php
+
+namespace App\Endpoint\Api\Http\Controllers;
+
+use Illuminate\Foundation\Auth\Access\AuthorizesRequests;
+use Illuminate\Foundation\Bus\DispatchesJobs;
+use Illuminate\Foundation\Validation\ValidatesRequests;
+use Illuminate\Routing\Controller as BaseController;
+
+class Controller extends BaseController
+{
+    use AuthorizesRequests;
+    use DispatchesJobs;
+    use ValidatesRequests;
+}

app/Endpoint/Api/Http/Controllers/LoginController.php

@@ -1,11 +1,10 @@
 <?php
 
-namespace App\Http\Controllers\Api\V1\Auth;
+namespace App\Endpoint\Api\Http\Controllers;
 
 use App\Constants\Device;
+use App\Endpoint\Api\Http\Requests\LoginRequest;
 use App\Exceptions\BizException;
-use App\Http\Controllers\Api\V1\Controller;
-use App\Http\Requests\Api\V1\LoginRequest;
 use App\Models\User;
 use App\Services\CaptchaService;
 
@@ -14,7 +13,7 @@ class LoginController extends Controller
     /**
      * 登录
      *
-     * @param \App\Http\Requests\Api\V1\LoginRequest $request
+     * @param \App\Endpoint\Api\Http\Requests\LoginRequest $request
      * @param \App\Services\CaptchaService $captchaService
      * @return \Illuminate\Http\JsonResponse
      */

app/Endpoint/Api/Http/Controllers/RegisterController.php

@@ -1,11 +1,10 @@
 <?php
 
-namespace App\Http\Controllers\Api\V1\Auth;
+namespace App\Endpoint\Api\Http\Controllers;
 
 use App\Constants\Device;
+use App\Endpoint\Api\Http\Requests\RegisterRequest;
 use App\Exceptions\BizException;
-use App\Http\Controllers\Api\V1\Controller;
-use App\Http\Requests\Api\V1\RegisterRequest;
 use App\Models\SmsCode;
 use App\Models\User;
 use App\Models\UserInfo;
@@ -18,7 +17,7 @@ class RegisterController extends Controller
     /**
      * 注册
      *
-     * @param \App\Http\Requests\Api\V1\RegisterRequest $request
+     * @param \App\Endpoint\Api\Http\Requests\RegisterRequest $request
      * @param \App\Services\SmsCodeService $smsCodeService
      * @return \Illuminate\Http\JsonResponse
      */

app/Endpoint/Api/Http/Controllers/SmsCodeController.php

@@ -1,9 +1,9 @@
 <?php
 
-namespace App\Http\Controllers\Api\V1;
+namespace App\Endpoint\Api\Http\Controllers;
 
+use App\Endpoint\Api\Http\Requests\StoreSmsCodeRequest;
 use App\Exceptions\BizException;
-use App\Http\Requests\Api\V1\SmsCode\StoreRequest;
 use App\Services\CaptchaService;
 use App\Services\SmsCodeService;
 use Throwable;
@@ -13,7 +13,7 @@ class SmsCodeController extends Controller
     /**
      * 发送短信验证码
      *
-     * @param \App\Http\Requests\Api\V1\SmsCode\StoreRequest $request
+     * @param \App\Endpoint\Api\Http\Requests\StoreSmsCodeRequest $request
      * @param \App\Services\CaptchaService $captchaService
      * @param \App\Services\SmsCodeService $smsCodeService
      * @return \Illuminate\Http\Response
@@ -21,7 +21,7 @@ class SmsCodeController extends Controller
      * @throws \App\Exceptions\BizException
      */
     public function store(
-        StoreRequest $request,
+        StoreSmsCodeRequest $request,
         CaptchaService $captchaService,
         SmsCodeService $smsCodeService,
     ) {

app/Endpoint/Api/Http/Requests/LoginRequest.php

@@ -1,6 +1,6 @@
 <?php
 
-namespace App\Http\Requests\Api\V1;
+namespace App\Endpoint\Api\Http\Requests;
 
 use Illuminate\Foundation\Http\FormRequest;
 

app/Endpoint/Api/Http/Requests/RegisterRequest.php

@@ -1,6 +1,6 @@
 <?php
 
-namespace App\Http\Requests\Api\V1;
+namespace App\Endpoint\Api\Http\Requests;
 
 use App\Models\User;
 use App\Rules\PhoneNumber;

app/Endpoint/Api/Http/Requests/StoreCaptchaRequest.php

@@ -0,0 +1,32 @@
+<?php
+
+namespace App\Endpoint\Api\Http\Requests;
+
+use Illuminate\Foundation\Http\FormRequest;
+
+class StoreCaptchaRequest extends FormRequest
+{
+    /**
+     * Determine if the user is authorized to make this request.
+     *
+     * @return bool
+     */
+    public function authorize()
+    {
+        return true;
+    }
+
+    /**
+     * Get the validation rules that apply to the request.
+     *
+     * @return array
+     */
+    public function rules()
+    {
+        return [
+            'key' => ['bail', 'filled', 'string', 'max:32'],
+            'w' => ['bail', 'int'],
+            'h' => ['bail', 'int'],
+        ];
+    }
+}

app/Endpoint/Api/Http/Requests/StoreSmsCodeRequest.php

@@ -1,11 +1,11 @@
 <?php
 
-namespace App\Http\Requests\Api\V1\SmsCode;
+namespace App\Endpoint\Api\Http\Requests;
 
 use App\Rules\PhoneNumber;
 use Illuminate\Foundation\Http\FormRequest;
 
-class StoreRequest extends FormRequest
+class StoreSmsCodeRequest extends FormRequest
 {
     /**
      * Determine if the user is authorized to make this request.

app/Endpoint/Api/Http/Resources/AdResource.php

@@ -1,6 +1,6 @@
 <?php
 
-namespace App\Http\Resources;
+namespace App\Endpoint\Api\Http\Resources;
 
 use Illuminate\Http\Resources\Json\JsonResource;
 
@@ -15,9 +15,9 @@ class AdResource extends JsonResource
     public function toArray($request)
     {
         return [
-            'image'=>$this->image,
+            'image' => (string) $this->image,
             'jump_type' => $this->jump_type,
-            'jump_link'=>$this->jump_link ?: '',
+            'jump_link' => (string) $this->jump_link,
         ];
     }
 }

app/Endpoint/Api/routes.php

@@ -0,0 +1,21 @@
+<?php
+
+use App\Endpoint\Api\Http\Controllers\AdController;
+use App\Endpoint\Api\Http\Controllers\CaptchaController;
+use App\Endpoint\Api\Http\Controllers\LoginController;
+use App\Endpoint\Api\Http\Controllers\RegisterController;
+use App\Endpoint\Api\Http\Controllers\SmsCodeController;
+use Illuminate\Support\Facades\Route;
+
+Route::group([
+    'prefix' => 'v1',
+], function () {
+    Route::post('captchas', [CaptchaController::class, 'store']);
+    Route::get('captchas/{captcha}', [CaptchaController::class, 'show']);
+    Route::post('sms-codes', [SmsCodeController::class, 'store']);
+
+    Route::post('login', LoginController::class);
+    Route::post('register', RegisterController::class);
+
+    Route::get('ads', [AdController::class, 'index']);
+});

app/Http/Controllers/Api/V1/AdController.php

@@ -1,26 +0,0 @@
-<?php
-
-namespace App\Http\Controllers\Api\V1;
-
-use App\Http\Resources\AdAddressResource;
-use App\Models\AdAddress;
-use Illuminate\Http\Request;
-
-class AdController extends Controller
-{
-    public function index(Request $request)
-    {
-        $addreseKeys = (array) $request->input('address_key');
-
-        $list = AdAddress::with(['ads'=>function ($query) {
-            $query->where('is_show', 1)->orderBy('sort', 'desc');
-        }])->where('is_show', 1)->whereIn('key', $addreseKeys)->get();
-
-        $data = [];
-        foreach ($addreseKeys as $key) {
-            $data[$key] = [];
-        }
-        $data = array_merge($data, array_column(AdAddressResource::collection($list)->toArray($request), 'ads', 'key'));
-        return $data;
-    }
-}

app/Http/Controllers/Api/V1/Controller.php

@@ -1,9 +0,0 @@
-<?php
-
-namespace App\Http\Controllers\Api\V1;
-
-use App\Http\Controllers\Controller as BaseController;
-
-class Controller extends BaseController
-{
-}

app/Http/Resources/AdAddressResource.php

@@ -1,22 +0,0 @@
-<?php
-
-namespace App\Http\Resources;
-
-use Illuminate\Http\Resources\Json\JsonResource;
-
-class AdAddressResource extends JsonResource
-{
-    /**
-     * Transform the resource into an array.
-     *
-     * @param  \Illuminate\Http\Request  $request
-     * @return array|\Illuminate\Contracts\Support\Arrayable|\JsonSerializable
-     */
-    public function toArray($request)
-    {
-        return [
-            'key' => $this->key,
-            'ads' => AdResource::collection($this->ads),
-        ];
-    }
-}

app/Providers/RouteServiceProvider.php

@@ -41,7 +41,7 @@ class RouteServiceProvider extends ServiceProvider
             Route::prefix('api')
                 ->middleware('api')
                 ->namespace($this->namespace)
-                ->group(base_path('routes/api.php'));
+                ->group(app_path('Endpoint/Api/routes.php'));
 
             Route::middleware('web')
                 ->namespace($this->namespace)

routes/api.php

@@ -1,12 +0,0 @@
-<?php
-
-use Illuminate\Support\Facades\File;
-use Illuminate\Support\Facades\Route;
-
-Route::group([
-    'prefix' => 'v1',
-], function () {
-    foreach (File::allFiles(base_path('routes/api/v1')) as $file) {
-        require $file;
-    }
-});

routes/api/v1/auth.php

@@ -1,8 +0,0 @@
-<?php
-
-use App\Http\Controllers\Api\V1\Auth\LoginController;
-use App\Http\Controllers\Api\V1\Auth\RegisterController;
-use Illuminate\Support\Facades\Route;
-
-Route::post('login', LoginController::class);
-Route::post('register', RegisterController::class);

routes/api/v1/common.php

@@ -1,12 +0,0 @@
-<?php
-
-use App\Http\Controllers\Api\V1\AdController;
-use App\Http\Controllers\Api\V1\CaptchaController;
-use App\Http\Controllers\Api\V1\SmsCodeController;
-use Illuminate\Support\Facades\Route;
-
-Route::post('captchas', [CaptchaController::class, 'store']);
-Route::get('captchas/{captcha}', [CaptchaController::class, 'show']);
-
-Route::post('sms-codes', [SmsCodeController::class, 'store']);
-Route::get('ads', [AdController::class, 'index']);